netdev - Re: [PATCH 3/3] dt-bindings: net: add schema for NXP S32 dwmac glue driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <171054478795.2084826.7994527965167081853.robh@kernel.org>
Date: Fri, 15 Mar 2024 17:19:49 -0600
From: Rob Herring <robh@...nel.org>
To: Wadim Mueller <wafgo01@...il.com>
Cc: Andreas Färber <afaerber@...e.de>, 
 Eric Dumazet <edumazet@...gle.com>, Conor Dooley <conor+dt@...nel.org>, 
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, 
 Shawn Guo <shawnguo@...nel.org>, Stephen Boyd <sboyd@...nel.org>, 
 linux-arm-kernel@...ts.infradead.org, Rob Herring <robh+dt@...nel.org>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Richard Cochran <richardcochran@...il.com>, 
 linux-stm32@...md-mailman.stormreply.com, 
 Shenwei Wang <shenwei.wang@....com>, Matthias Brugger <mbrugger@...e.com>, 
 Pengutronix Kernel Team <kernel@...gutronix.de>, 
 "David S. Miller" <davem@...emloft.net>, linux-kernel@...r.kernel.org, 
 Giuseppe Cavallaro <peppe.cavallaro@...com>, 
 Simon Horman <horms@...nel.org>, devicetree@...r.kernel.org, 
 netdev@...r.kernel.org, Fabio Estevam <festevam@...il.com>, 
 Johannes Zink <j.zink@...gutronix.de>, linux-clk@...r.kernel.org, 
 Sascha Hauer <s.hauer@...gutronix.de>, NXP Linux Team <linux-imx@....com>, 
 Maxime Coquelin <mcoquelin.stm32@...il.com>, 
 Andrew Halaney <ahalaney@...hat.com>, Jose Abreu <joabreu@...opsys.com>, 
 Swee Leong Ching <leong.ching.swee@...el.com>, 
 Chester Lin <chester62515@...il.com>, 
 Alexandre Torgue <alexandre.torgue@...s.st.com>, 
 Paolo Abeni <pabeni@...hat.com>, NXP S32 Linux Team <s32@....com>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
 "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, 
 Michael Turquette <mturquette@...libre.com>
Subject: Re: [PATCH 3/3] dt-bindings: net: add schema for NXP S32 dwmac
 glue driver

On Fri, 15 Mar 2024 23:27:49 +0100, Wadim Mueller wrote:
> Add DT binding schema documentation for the NXP S32 dwmac glue driver. This documentation is based on the patchset originally provided by Chester Lin [1]. This commit is a re-send of [2] and [3].
> 
> [1] https://patchwork.kernel.org/project/netdevbpf/patch/20221031101052.14956-6-clin@suse.com/#25068228
> [2] https://lore.kernel.org/lkml/20221031101052.14956-1-clin@suse.com/T/#me96c28bd0536de276dee941469ea084d51b42244
> [3] https://lore.kernel.org/lkml/20221031101052.14956-1-clin@suse.com/T/#m887a1b34e612f8dc0d5b718e4d6834c083f1e245
> 
> Signed-off-by: Wadim Mueller <wafgo01@...il.com>
> ---
>  .../bindings/net/nxp,s32-dwmac.yaml           | 130 ++++++++++++++++++
>  .../devicetree/bindings/net/snps,dwmac.yaml   |   5 +-
>  2 files changed, 133 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml:5:10: [error] string value is redundantly quoted with any quotes (quoted-strings)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml: 'maintainers' is a required property
	hint: Metaschema for devicetree binding documentation
	from schema $id: http://devicetree.org/meta-schemas/base.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240315222754.22366-4-wafgo01@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.