netdev - Re: [PATCH net-next v4 8/8] virtio-net: support queue stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1710490258.2804203-2-xuanzhuo@linux.alibaba.com>
Date: Fri, 15 Mar 2024 16:10:58 +0800
From: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>,
 Eric  Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>,
 "Michael S.  Tsirkin" <mst@...hat.com>,
 Jason Wang <jasowang@...hat.com>,
 Alexei  Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Stanislav Fomichev <sdf@...gle.com>,
 Amritha  Nambiar <amritha.nambiar@...el.com>,
 Larysa Zaremba <larysa.zaremba@...el.com>,
 Sridhar Samudrala <sridhar.samudrala@...el.com>,
 Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
 virtualization@...ts.linux.dev,
 bpf@...r.kernel.org
Subject: Re: [PATCH net-next v4 8/8] virtio-net: support queue stat

On Thu, 14 Mar 2024 15:56:16 -0700, Jakub Kicinski <kuba@...nel.org> wrote:
> On Thu, 14 Mar 2024 16:54:59 +0800 Xuan Zhuo wrote:
> > +static void virtnet_get_base_stats(struct net_device *dev,
> > +				   struct netdev_queue_stats_rx *rx,
> > +				   struct netdev_queue_stats_tx *tx)
> > +{
> > +	/* The queue stats of the virtio-net will not be reset. So here we
> > +	 * return 0.
> > +	 */
> > +	memset(rx, 0, sizeof(*rx));
> > +	memset(tx, 0, sizeof(*tx));
> > +}
>
> /**
>  * struct netdev_stat_ops - netdev ops for fine grained stats
>  * @get_queue_stats_rx:	get stats for a given Rx queue
>  * @get_queue_stats_tx:	get stats for a given Tx queue
>  * @get_base_stats:	get base stats (not belonging to any live instance)
>  *
>  * Query stats for a given object. The values of the statistics are undefined
>  * on entry (specifically they are *not* zero-initialized). Drivers should
>  * assign values only to the statistics they collect. Statistics which are not
>  * collected must be left undefined.                  ^^^^^^^^^^^^^^^^^^^^^^^^
>    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I see.

Thanks.