netdev - Re: [PATCH iproute2-next v2 2/4] ip: ipnexthop: Support dumping next hop group stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87il1nkalr.fsf@nvidia.com>
Date: Fri, 15 Mar 2024 12:15:51 +0100
From: Petr Machata <petrm@...dia.com>
To: Stephen Hemminger <stephen@...workplumber.org>
CC: Petr Machata <petrm@...dia.com>, David Ahern <dsahern@...nel.org>,
	<netdev@...r.kernel.org>, Ido Schimmel <idosch@...dia.com>, Jakub Kicinski
	<kuba@...nel.org>, <mlxsw@...dia.com>
Subject: Re: [PATCH iproute2-next v2 2/4] ip: ipnexthop: Support dumping
 next hop group stats


Stephen Hemminger <stephen@...workplumber.org> writes:

> On Thu, 14 Mar 2024 15:52:13 +0100
> Petr Machata <petrm@...dia.com> wrote:
>
>> Next hop group stats allow verification of balancedness of a next hop
>> group. The feature was merged in kernel commit 7cf497e5a122 ("Merge branch
>> 'nexthop-group-stats'"). Add to ip the corresponding support. The
>> statistics are requested if "ip nexthop" is started with -s.
>> 
>> Signed-off-by: Petr Machata <petrm@...dia.com>
>
> Checkpatch complains:
>
> WARNING: braces {} are not necessary for single statement blocks
> #273: FILE: ip/ipnexthop.c:568:
> +	if (show_stats) {
> +		op_flags |= NHA_OP_FLAG_DUMP_STATS;
> +	}
>
> total: 0 erro

Yes. The next patch adds more code to that branch.