netdev - Re: [PATCH net 3/3] net: hns3: mark unexcuted loopback test result as UNEXECUTED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5178c9fa-711a-4a91-ba1c-4b10da7592b3@huawei.com>
Date: Sat, 16 Mar 2024 19:17:55 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Michal Kubiak <michal.kubiak@...el.com>
CC: <shaojijie@...wei.com>, <yisen.zhuang@...wei.com>,
	<salil.mehta@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <shenjian15@...wei.com>,
	<wangjie125@...wei.com>, <liuyonglong@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net 3/3] net: hns3: mark unexcuted loopback test result as
 UNEXECUTED


on 2024/3/16 2:07, Michal Kubiak wrote:
> On Fri, Mar 15, 2024 at 06:07:48PM +0800, Jijie Shao wrote:
>> From: Jian Shen <shenjian15@...wei.com>
>>
>> Currently, loopback test maybe skipped when resetting, but the test
> typo: maybe skipped -> may be skipped
>
>> result will still show as 'PASS', because the driver doesn't set
>> ETH_TEST_FL_FAILED flag. Fixes it by set the flag and initialize the
>> value to be UNEXECUTED.
> Fix it by setting the flag and initializating the value to UNEXECUTED.
>
>
>> Fixes: 4c8dab1c709c ("net: hns3: reconstruct function hns3_self_test")
>> Signed-off-by: Jian Shen <shenjian15@...wei.com>

Thanks，

I have sent V2 to fix them.

Jijie