netdev - RE: [patch net] devlink: fix port new reply cmd type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH0PR12MB548144194C053A632B9397FDDC2D2@PH0PR12MB5481.namprd12.prod.outlook.com>
Date: Mon, 18 Mar 2024 13:57:21 +0000
From: Parav Pandit <parav@...dia.com>
To: Jiri Pirko <jiri@...nulli.us>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>
Subject: RE: [patch net] devlink: fix port new reply cmd type

> From: Jiri Pirko <jiri@...nulli.us>
> Sent: Monday, March 18, 2024 2:49 PM
> To: netdev@...r.kernel.org
> Cc: kuba@...nel.org; pabeni@...hat.com; davem@...emloft.net;
> edumazet@...gle.com; Parav Pandit <parav@...dia.com>
> 
> From: Jiri Pirko <jiri@...dia.com>
> 
> Due to a c&p error, port new reply fills-up cmd with wrong value, any other
> existing port command replies and notifications.
> 
I didn't understand 'c&p' error. Did you mean command and port?

> Fix it by filling cmd with value DEVLINK_CMD_PORT_NEW.
> 
> Skimmed through devlink userspace implementations, none of them cares
> about this cmd value.
> 
> Reported-by: Chenyuan Yang <chenyuan0y@...il.com>
> Closes: https://lore.kernel.org/all/ZfZcDxGV3tSy4qsV@cy-server/
> Fixes: cd76dcd68d96 ("devlink: Support add and delete devlink port")
> Signed-off-by: Jiri Pirko <jiri@...dia.com>
> ---
>  net/devlink/port.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/devlink/port.c b/net/devlink/port.c index
> 4b2d46ccfe48..118d130d2afd 100644
> --- a/net/devlink/port.c
> +++ b/net/devlink/port.c
> @@ -889,7 +889,7 @@ int devlink_nl_port_new_doit(struct sk_buff *skb,
> struct genl_info *info)
>  		err = -ENOMEM;
>  		goto err_out_port_del;
>  	}
> -	err = devlink_nl_port_fill(msg, devlink_port, DEVLINK_CMD_NEW,
> +	err = devlink_nl_port_fill(msg, devlink_port,
> DEVLINK_CMD_PORT_NEW,
>  				   info->snd_portid, info->snd_seq, 0, NULL);
>  	if (WARN_ON_ONCE(err))
>  		goto err_out_msg_free;
> --
> 2.44.0

Subject should start with upper case.. 

Thanks,
Reviewed-by: Parav Pandit <parav@...dia.com>