netdev - [PATCH iproute2 v2] ifstat: handle strdup return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240318091541.2595-1-dkirjanov@suse.de>
Date: Mon, 18 Mar 2024 05:15:41 -0400
From: Denis Kirjanov <kirjanov@...il.com>
To: stephen@...workplumber.org,
	dsahern@...nel.org
Cc: netdev@...r.kernel.org,
	Denis Kirjanov <dkirjanov@...e.de>
Subject: [PATCH iproute2 v2] ifstat: handle strdup return value

get_nlmsg_extended is missing the check as
it's done in get_nlmsg

v2: don't set the errno value explicitly

Signed-off-by: Denis Kirjanov <dkirjanov@...e.de>
---
 misc/ifstat.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/misc/ifstat.c b/misc/ifstat.c
index 685e66c9..352e5622 100644
--- a/misc/ifstat.c
+++ b/misc/ifstat.c
@@ -140,6 +140,10 @@ static int get_nlmsg_extended(struct nlmsghdr *m, void *arg)
 
 	n->ifindex = ifsm->ifindex;
 	n->name = strdup(ll_index_to_name(ifsm->ifindex));
+	if (!n->name) {
+		free(n);
+		return -1;
+	}
 
 	if (sub_type == NO_SUB_TYPE) {
 		memcpy(&n->val, RTA_DATA(tb[filter_type]), sizeof(n->val));
-- 
2.30.2