netdev - Re: [PATCH] net/mlx5: offset comp irq index in name by one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <805b1189-db3a-4763-87de-f55e94c6d8db@nvidia.com>
Date: Tue, 19 Mar 2024 08:39:50 +0200
From: Shay Drori <shayd@...dia.com>
To: Michael Liang <mliang@...estorage.com>, Saeed Mahameed <saeedm@...dia.com>
CC: Tariq Toukan <tariqt@...dia.com>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <stable@...r.kernel.org>, Mohamed Khalfella
	<mkhalfella@...estorage.com>, Yuanyuan Zhong <yzhong@...estorage.com>
Subject: Re: [PATCH] net/mlx5: offset comp irq index in name by one


On 12/03/2024 0:30, Michael Liang wrote:
> The mlx5 comp irq name scheme is changed a little bit between
> commit 3663ad34bc70 ("net/mlx5: Shift control IRQ to the last index")
> and commit 3354822cde5a ("net/mlx5: Use dynamic msix vectors allocation").
> The index in the comp irq name used to start from 0 but now it starts
> from 1. There is nothing critical here, but it's harmless to change
> back to the old behavior, a.k.a starting from 0.
>
> Fixes: 3354822cde5a ("net/mlx5: Use dynamic msix vectors allocation")
> Reviewed-by: Mohamed Khalfella <mkhalfella@...estorage.com>
> Reviewed-by: Yuanyuan Zhong <yzhong@...estorage.com>
> Signed-off-by: Michael Liang <mliang@...estorage.com>
Reviewed-by: Shay Drory <shayd@...dia.com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
> index 4dcf995cb1a2..6bac8ad70ba6 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
> @@ -19,6 +19,7 @@
>   #define MLX5_IRQ_CTRL_SF_MAX 8
>   /* min num of vectors for SFs to be enabled */
>   #define MLX5_IRQ_VEC_COMP_BASE_SF 2
> +#define MLX5_IRQ_VEC_COMP_BASE 1
>   
>   #define MLX5_EQ_SHARE_IRQ_MAX_COMP (8)
>   #define MLX5_EQ_SHARE_IRQ_MAX_CTRL (UINT_MAX)
> @@ -246,6 +247,7 @@ static void irq_set_name(struct mlx5_irq_pool *pool, char *name, int vecidx)
>   		return;
>   	}
>   
> +	vecidx -= MLX5_IRQ_VEC_COMP_BASE;
>   	snprintf(name, MLX5_MAX_IRQ_NAME, "mlx5_comp%d", vecidx);
>   }
>   
> @@ -585,7 +587,7 @@ struct mlx5_irq *mlx5_irq_request_vector(struct mlx5_core_dev *dev, u16 cpu,
>   	struct mlx5_irq_table *table = mlx5_irq_table_get(dev);
>   	struct mlx5_irq_pool *pool = table->pcif_pool;
>   	struct irq_affinity_desc af_desc;
> -	int offset = 1;
> +	int offset = MLX5_IRQ_VEC_COMP_BASE;
>   
>   	if (!pool->xa_num_irqs.max)
>   		offset = 0;