netdev - [PATCH] net: ll_temac: platform_get_resource replaced by wrong function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <41c3ea1df1af4f03b2c66728af6812fb@terma.com>
Date: Tue, 19 Mar 2024 19:45:26 +0000
From: Claus Hansen Ries <chr@...ma.com>
To: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net"
	<davem@...emloft.net>
Subject: [PATCH] net: ll_temac: platform_get_resource replaced by wrong
 function

From: Claus Hansen ries <chr@...ma.com>

devm_platform_ioremap_resource_byname is called using 0 as name, which eventually 
ends up in platform_get_resource_byname, where it causes a null pointer in strcmp.

                if (type == resource_type(r) && !strcmp(r->name, name))

The correct function is devm_platform_ioremap_resource.

Fixes: bd69058 ("net: ll_temac: Use devm_platform_ioremap_resource_byname()")
Signed-off-by: Claus H. Ries <chr@...ma.com>
Cc: stable@...r.kernel.org
---
 drivers/net/ethernet/xilinx/ll_temac_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 9df39cf8b097..1072e2210aed 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -1443,7 +1443,7 @@ static int temac_probe(struct platform_device *pdev)
        }
          /* map device registers */
-       lp->regs = devm_platform_ioremap_resource_byname(pdev, 0);
+       lp->regs = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(lp->regs)) {
                dev_err(&pdev->dev, "could not map TEMAC registers\n");
                return -ENOMEM;

base-commit: d95fcdf4961d27a3d17e5c7728367197adc89b8d
--  2.39.3 (Apple Git-146)