netdev - Re: [PATCH net v3] net: esp: fix bad handling of pages from page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zfk5uxupr5ntQui9@gauss3.secunet.de>
Date: Tue, 19 Mar 2024 08:07:39 +0100
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Dragos Tatulea <dtatulea@...dia.com>
CC: <almasrymina@...gle.com>, Herbert Xu <herbert@...dor.apana.org.au>, "David
 S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Jesper Dangaard Brouer <brouer@...hat.com>, Matteo Croce
	<mcroce@...rosoft.com>, Ilias Apalodimas <ilias.apalodimas@...aro.org>,
	<leonro@...dia.com>, <gal@...dia.com>, <stable@...r.kernel.org>, "Anatoli N .
 Chechelnickiy" <Anatoli.Chechelnickiy@...nterpipe.biz>, Ian Kumlien
	<ian.kumlien@...il.com>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net v3] net: esp: fix bad handling of pages from page_pool

On Fri, Mar 08, 2024 at 05:26:00PM +0200, Dragos Tatulea wrote:
> When the skb is reorganized during esp_output (!esp->inline), the pages
> coming from the original skb fragments are supposed to be released back
> to the system through put_page. But if the skb fragment pages are
> originating from a page_pool, calling put_page on them will trigger a
> page_pool leak which will eventually result in a crash.
> 
> This leak can be easily observed when using CONFIG_DEBUG_VM and doing
> ipsec + gre (non offloaded) forwarding:

...

> The suggested fix is to introduce a new wrapper (skb_page_unref) that
> covers page refcounting for page_pool pages as well.
> 
> Cc: stable@...r.kernel.org
> Fixes: 6a5bcd84e886 ("page_pool: Allow drivers to hint on SKB recycling")
> Reported-and-tested-by: Anatoli N.Chechelnickiy <Anatoli.Chechelnickiy@...nterpipe.biz>
> Reported-by: Ian Kumlien <ian.kumlien@...il.com>
> Link: https://lore.kernel.org/netdev/CAA85sZvvHtrpTQRqdaOx6gd55zPAVsqMYk_Lwh4Md5knTq7AyA@mail.gmail.com
> Signed-off-by: Dragos Tatulea <dtatulea@...dia.com>
> Reviewed-by: Mina Almasry <almasrymina@...gle.com>
> Reviewed-by: Jakub Kicinski <kuba@...nel.org>

Applied to the ipsec tree, thanks a lot!