netdev - Re: [PATCH xfrm] xfrm: Allow UDP encapsulation only in offload modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 19 Mar 2024 11:27:43 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Steffen Klassert <steffen.klassert@...unet.com>, Leon Romanovsky
	 <leon@...nel.org>
Cc: Leon Romanovsky <leonro@...dia.com>, "David S. Miller"
 <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>, Herbert Xu
 <herbert@...dor.apana.org.au>, Jakub Kicinski <kuba@...nel.org>, 
 netdev@...r.kernel.org
Subject: Re: [PATCH xfrm] xfrm: Allow UDP encapsulation only in offload modes

On Tue, 2024-03-19 at 08:08 +0100, Steffen Klassert wrote:
> On Tue, Mar 12, 2024 at 01:55:22PM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@...dia.com>
> > 
> > The missing check of x->encap caused to the situation where GSO packets
> > were created with UDP encapsulation.
> > 
> > As a solution return the encap check for non-offloaded SA.
> > 
> > Fixes: 9f2b55961a80 ("xfrm: Pass UDP encapsulation in TX packet offload")
> > Closes: https://lore.kernel.org/all/a650221ae500f0c7cf496c61c96c1b103dcb6f67.camel@redhat.com
> > Reported-by: Paolo Abeni <pabeni@...hat.com>
> > Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> 
> Applied, thanks Leon!

Steffen, as the issue addressed here is causing self-test failures in
our CI, could you please send the PR including this change somewhat
soonish? 

Many thanks,

Paolo