netdev - Re: [Intel-wired-lan] [PATCH iwl-next v7 1/6] devlink: extend devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e5d306a9-d44e-442e-bd9c-34cc272b78cd@intel.com>
Date: Tue, 19 Mar 2024 12:41:57 +0100
From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
To: Simon Horman <horms@...nel.org>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<anthony.l.nguyen@...el.com>, <kuba@...nel.org>, <jiri@...nulli.us>,
	<przemyslaw.kitszel@...el.com>, <andrew@...n.ch>, <victor.raj@...el.com>,
	<michal.wilczynski@...el.com>, <lukasz.czapnik@...el.com>, Jiri Pirko
	<jiri@...dia.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v7 1/6] devlink: extend
 devlink_param *set pointer

On 3/18/2024 9:02 PM, Simon Horman wrote:
> On Fri, Mar 08, 2024 at 06:39:14AM -0500, Mateusz Polchlopek wrote:
>> Extend devlink_param *set function pointer to take extack as a param.
>> Sometimes it is needed to pass information to the end user from set
>> function. It is more proper to use for that netlink instead of passing
>> message to dmesg.
>>
>> Reviewed-by: Jiri Pirko <jiri@...dia.com>
>> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
> 
> Hi Mateusz,
>  > FWIIW, I think there are several (new?) users of this callback
> present in net-next now which will also need to be updated.

Hi Simon

Yes, You are right, I am aware of that and this will be fixed in the
next version of this patch, thanks.