netdev - Re: [PATCH net] selftests: forwarding: Fix ping failure due to short timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZfriEc8i3A5jPMmg@nanopsycho>
Date: Wed, 20 Mar 2024 14:18:09 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Ido Schimmel <idosch@...dia.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
	pabeni@...hat.com, edumazet@...gle.com, amcohen@...dia.com,
	petrm@...dia.com
Subject: Re: [PATCH net] selftests: forwarding: Fix ping failure due to short
 timeout

Wed, Mar 20, 2024 at 07:57:17AM CET, idosch@...dia.com wrote:
>The tests send 100 pings in 0.1 second intervals and force a timeout of
>11 seconds, which is borderline (especially on debug kernels), resulting
>in random failures in netdev CI [1].
>
>Fix by increasing the timeout to 20 seconds. It should not prolong the
>test unless something is wrong, in which case the test will rightfully
>fail.
>
>[1]
> # selftests: net/forwarding: vxlan_bridge_1d_port_8472_ipv6.sh
> # INFO: Running tests with UDP port 8472
> # TEST: ping: local->local                                            [ OK ]
> # TEST: ping: local->remote 1                                         [FAIL]
> # Ping failed
> [...]
>
>Fixes: b07e9957f220 ("selftests: forwarding: Add VxLAN tests with a VLAN-unaware bridge for IPv6")
>Fixes: 728b35259e28 ("selftests: forwarding: Add VxLAN tests with a VLAN-aware bridge for IPv6")
>Reported-by: Paolo Abeni <pabeni@...hat.com>
>Closes: https://lore.kernel.org/netdev/24a7051fdcd1f156c3704bca39e4b3c41dfc7c4b.camel@redhat.com/
>Signed-off-by: Ido Schimmel <idosch@...dia.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>