[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAL_JsqLep6DDecq-HonMd8HF0hD7xGB_ucbZrYUYJSx8t28fFQ@mail.gmail.com>
Date: Wed, 20 Mar 2024 11:30:02 -0500
From: Rob Herring <robh@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Simon Horman <horms@...nel.org>, Claus Hansen Ries <chr@...ma.com>, netdev@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Michal Simek <michal.simek@....com>,
Alex Elder <elder@...aro.org>, Wei Fang <wei.fang@....com>,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
Wang Hai <wanghai38@...wei.com>
Subject: Re: [PATCH] net: ll_temac: platform_get_resource replaced by wrong function
On Wed, Mar 20, 2024 at 10:13 AM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> On Wed, Mar 20, 2024 at 11:54:33AM +0000, Simon Horman wrote:
> > > ---
> > > drivers/net/ethernet/xilinx/ll_temac_main.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
> > > index 9df39cf8b097..1072e2210aed 100644
> > > --- a/drivers/net/ethernet/xilinx/ll_temac_main.c
> > > +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
> > > @@ -1443,7 +1443,7 @@ static int temac_probe(struct platform_device *pdev)
> > > }
> > > /* map device registers */
> > > - lp->regs = devm_platform_ioremap_resource_byname(pdev, 0);
> > > + lp->regs = devm_platform_ioremap_resource(pdev, 0);
>
> This should have triggered a Sparse warning "warning: Using plain
> integer as NULL pointer" but the problem is that this file does not have
> correct endian annotations and after a certain number of warnings Sparse
> gives up.
It did[1] along with linker errors on s390. Just no one was CC'ed
other than the author. I guess 0-day gave up after a while.
Rob
[1] https://lore.kernel.org/all/202008070052.yH1Em3c1%25lkp@intel.com/
Powered by blists - more mailing lists