netdev - Re: [PATCH v4 1/4] dt-bindings: bluetooth: add 'qcom,local-bd-address-broken'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <171095471407.2028655.14348528428018722281.robh@kernel.org>
Date: Wed, 20 Mar 2024 12:11:54 -0500
From: Rob Herring <robh@...nel.org>
To: Johan Hovold <johan+linaro@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Konrad Dybcio <konrad.dybcio@...aro.org>,
	Marcel Holtmann <marcel@...tmann.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	Luiz Augusto von Dentz <luiz.dentz@...il.com>,
	Rocky Liao <quic_rjliao@...cinc.com>,
	linux-bluetooth@...r.kernel.org,
	cros-qcom-dts-watchers@...omium.org, linux-kernel@...r.kernel.org,
	Bjorn Andersson <andersson@...nel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	devicetree@...r.kernel.org, netdev@...r.kernel.org,
	Douglas Anderson <dianders@...omium.org>,
	Matthias Kaehlcke <mka@...omium.org>,
	Balakrishna Godavarthi <quic_bgodavar@...cinc.com>
Subject: Re: [PATCH v4 1/4] dt-bindings: bluetooth: add
 'qcom,local-bd-address-broken'


On Wed, 20 Mar 2024 08:55:51 +0100, Johan Hovold wrote:
> Several Qualcomm Bluetooth controllers lack persistent storage for the
> device address and instead one can be provided by the boot firmware
> using the 'local-bd-address' devicetree property.
> 
> The Bluetooth bindings clearly states that the address should be
> specified in little-endian order, but due to a long-standing bug in the
> Qualcomm driver which reversed the address some boot firmware has been
> providing the address in big-endian order instead.
> 
> The only device out there that should be affected by this is the WCN3991
> used in some Chromebooks.
> 
> Add a 'qcom,local-bd-address-broken' property which can be set on these
> platforms to indicate that the boot firmware is using the wrong byte
> order.
> 
> Note that ChromeOS always updates the kernel and devicetree in lockstep
> so that there is no need to handle backwards compatibility with older
> devicetrees.
> 
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
>  .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Reviewed-by: Rob Herring <robh@...nel.org>