netdev - Re: [PATCH net] net: txgbe: fix i2c dev name cannot match clkdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZfrhNFPYjBsMrbbl@nanopsycho>
Date: Wed, 20 Mar 2024 14:14:28 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Duanqiang Wen <duanqiangwen@...-swift.com>
Cc: netdev@...r.kernel.org, jiawenwu@...stnetic.com,
	mengyuanlou@...-swift.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, maciej.fijalkowski@...el.com,
	andrew@...n.ch, wangxiongfeng2@...wei.com
Subject: Re: [PATCH net] net: txgbe: fix i2c dev name cannot match clkdev

Wed, Mar 20, 2024 at 04:22:24AM CET, duanqiangwen@...-swift.com wrote:
>txgbe clkdev shortened clk_name, so i2c_dev info_name
>also need to shorten. Otherwise, i2c_dev cannot initialize
>clock.
>
>Fixes: e30cef001da2 ("net: txgbe: fix clk_name exceed MAX_DEV_ID limits")
>
>Signed-off-by: Duanqiang Wen <duanqiangwen@...-swift.com>
>---
> drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
>index 5b5d5e4310d1..84d04e231b88 100644
>--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
>+++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
>@@ -634,7 +634,7 @@ static int txgbe_i2c_register(struct txgbe *txgbe)
> 
> 	info.parent = &pdev->dev;
> 	info.fwnode = software_node_fwnode(txgbe->nodes.group[SWNODE_I2C]);
>-	info.name = "i2c_designware";
>+	info.name = "i2c_dw";

Perhaps this is very good reason to have this string in a define?


> 	info.id = pci_dev_id(pdev);
> 
> 	info.res = &DEFINE_RES_IRQ(pdev->irq);
>-- 
>2.27.0
>
>