netdev - Re: [PATCH v2 3/5] net: marvell: prestera: fix memory use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0158f0e-62c5-4eb4-8944-0d1cb0492687@lunn.ch>
Date: Thu, 21 Mar 2024 01:14:19 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Elad Nachman <enachman@...vell.com>
Cc: taras.chornyi@...ision.eu, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, kory.maincent@...tlin.com,
	thomas.petazzoni@...tlin.com, miquel.raynal@...tlin.com,
	przemyslaw.kitszel@...el.com, dkirjanov@...e.de,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/5] net: marvell: prestera: fix memory use after free

On Wed, Mar 20, 2024 at 07:20:06PM +0200, Elad Nachman wrote:
> From: Elad Nachman <enachman@...vell.com>
> 
> Prestera driver routing module cleanup process would release memory,
> then reference it again and eventually free it again the second time.
> 
> Remove the redundant first memory free call.
> All such double free calls were detected using KASAN.
> 
> Fixes: 4394fbcb78cf ("net: marvell: prestera: handle fib notifications")
> Signed-off-by: Elad Nachman <enachman@...vell.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew