netdev - Re: net: wwan: t7xx: BUG: Unaligned access when loading mtk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87il1ezdbd.fsf@miraculix.mork.no>
Date: Fri, 22 Mar 2024 13:00:22 +0100
From: Bjørn Mork <bjorn@...k.no>
To: Liviu Dudau <liviu@...au.co.uk>
Cc: Chandrashekar Devegowda <chandrashekar.devegowda@...el.com>,
        Haijun Liu <haijun.liu@...iatek.com>,
        Chiranjeevi Rapolu <chiranjeevi.rapolu@...ux.intel.com>,
        M Chetan Kumar <m.chetan.kumar@...ux.intel.com>,
        Ricardo Martinez <ricardo.martinez@...ux.intel.com>,
        Loic Poulain <loic.poulain@...aro.org>,
        Sergey Ryazanov <ryazanov.s.a@...il.com>,
        Johannes Berg <johannes@...solutions.net>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: net: wwan: t7xx: BUG: Unaligned access when loading mtk_t7xx
 module

Liviu Dudau <liviu@...au.co.uk> writes:

>  I had a
> go at guessing that UL registers are at 0x8 and 0x48 offsets and DL
> registers are at 0x0478 and 0x04b8, but while that fixes the alignment
> exception, I now get a "CLDMA{0,1} queue 0 is not empty" message.

I don't think you can assume the register offsets are wrong.  It looks
more like the device doesn't care about alignment.

But given that the driver includes <linux/io-64-nonatomic-lo-hi.h>, you
can probably replace those unaligned 64bit accesses with two nonatomic
32bit accesses.


Bjørn