netdev - Re: [PATCH net V1] net: lan743x: Add set RFE read fifo threshold for PCI1x1x chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240322123833.GC372561@kernel.org>
Date: Fri, 22 Mar 2024 12:38:33 +0000
From: Simon Horman <horms@...nel.org>
To: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
	pabeni@...hat.com, edumazet@...gle.com,
	linux-kernel@...r.kernel.org, bryan.whitehead@...rochip.com,
	UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net V1] net: lan743x: Add set RFE read fifo threshold for
 PCI1x1x chips

On Fri, Mar 22, 2024 at 12:16:50PM +0530, Raju Lakkaraju wrote:
> PCI11x1x Rev B0 devices might drop packets when receiving back to back frames
> at 2.5G link speed. Change the B0 Rev device's Receive filtering Engine FIFO
> threshold parameter from its hardware default of 4 to 3 dwords to prevent the
> problem. Rev C0 and later hardware already defaults to 3 dwords.
> 
> Fixes: bb4f6bffe33c ("net: lan743x: Add PCI11010 / PCI11414 device IDs")
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
> ---
> Change List:
> ------------
> V0 -> V1:
>   - misc_ctl change from int to unsigned int
>   - Use FIELD_PREP macro instead of logical shift operator
>   - Change 0x3 to macro RFE_RD_FIFO_TH_3_DWORDS

Thanks for the updates,

Reviewed-by: Simon Horman <horms@...nel.org>