netdev - Re: [PATCH 0/4] PCI: Consolidate TLP Log reading and printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <771bb522-c4eb-b515-e315-6ad1c622cbd9@linux.intel.com>
Date: Fri, 22 Mar 2024 16:16:37 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Bjorn Helgaas <helgaas@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>
cc: linux-pci@...r.kernel.org, Jesse Brandeburg <jesse.brandeburg@...el.com>, 
    intel-wired-lan@...ts.osuosl.org, Tony Nguyen <anthony.l.nguyen@...el.com>, 
    Ard Biesheuvel <ardb@...nel.org>, Borislav Petkov <bp@...en8.de>, 
    "David S. Miller" <davem@...emloft.net>, 
    Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
    linux-edac@...r.kernel.org, linux-efi@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>, linuxppc-dev@...ts.ozlabs.org, 
    Mahesh J Salgaonkar <mahesh@...ux.ibm.com>, 
    Netdev <netdev@...r.kernel.org>, Oliver O'Halloran <oohall@...il.com>, 
    Paolo Abeni <pabeni@...hat.com>, Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH 0/4] PCI: Consolidate TLP Log reading and printing

On Mon, 11 Mar 2024, Ilpo Järvinen wrote:

> On Fri, 8 Mar 2024, Bjorn Helgaas wrote:
> 
> > On Tue, Feb 06, 2024 at 03:57:13PM +0200, Ilpo Järvinen wrote:
> > > This series consolidates AER & DPC TLP Log handling code. Helpers are
> > > added for reading and printing the TLP Log and the format is made to
> > > include E-E Prefixes in both cases (previously only one DPC RP PIO
> > > displayed the E-E Prefixes).
> > > 
> > > I'd appreciate if people familiar with ixgbe could check the error
> > > handling conversion within the driver is correct.
> > > 
> > > Ilpo Järvinen (4):
> > >   PCI/AER: Cleanup register variable
> > >   PCI: Generalize TLP Header Log reading
> > 
> > I applied these first two to pci/aer for v6.9, thanks, these are all
> > nice improvements!
> > 
> > I postponed the ixgbe part for now because I think we should get an
> > ack from those maintainers or just send it to them since it subtly
> > changes the error and device removal checking there.
> 
> Okay, I'll make sure they're separated properly for the remaining patches 
> (I was already planning on doing that separation and posting v2 to avoid 
> their input blocking the changed but you beat me to it).
> 
> > >   PCI: Add TLP Prefix reading into pcie_read_tlp_log()
> > >   PCI: Create helper to print TLP Header and Prefix Log
> > 
> > I'll respond to these with some minor comments.
> 
> Did you forget to send those comments?

Ping.

I still haven't received those comments for patches 3 & 4.

-- 
 i.