netdev - Re: [PATCH RFC 2/7] net: Add helpers for netdev LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fc37850-e74a-47a8-9c74-2fa08b4eae9e@solid-run.com>
Date: Fri, 22 Mar 2024 18:33:28 +0000
From: Josua Mayer <josua@...id-run.com>
To: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>, Gregory
 Clement <gregory.clement@...tlin.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH RFC 2/7] net: Add helpers for netdev LEDs

Am 17.03.24 um 22:45 schrieb Andrew Lunn:
> Add a set of helpers for parsing the standard device tree properties
> for LEDs are part of an ethernet device, and registering them with the
> LED subsystem. This code can be used by any sort of netdev driver, DSA
> switch or pure switchdev switch driver.
>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---
> ...
>
> +struct netdev_leds_ops {
> +	int (*brightness_set)(struct net_device *ndev, u8 led,
> +			      enum led_brightness brightness);
> +	int (*blink_set)(struct net_device *ndev, u8 led,
> +			 unsigned long *delay_on,  unsigned long *delay_off);
> +	int (*hw_control_is_supported)(struct net_device *ndev, u8 led,
> +				       unsigned long flags);
> +	int (*hw_control_set)(struct net_device *ndev, u8 led,
> +			      unsigned long flags);
> +	int (*hw_control_get)(struct net_device *ndev, u8 led,
> +			      unsigned long *flags);
> +};
I noticed phy.h calls the "flags" argument "rules" instead,
perhaps that is more suitable.