netdev - Re: [PATCH net] tcp: properly terminate timers for kernel sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240322154704.7ed4d55f@kernel.org>
Date: Fri, 22 Mar 2024 15:47:04 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, netdev@...r.kernel.org, eric.dumazet@...il.com, Josef
 Bacik <josef@...icpanda.com>, Tetsuo Handa
 <penguin-kernel@...ove.SAKURA.ne.jp>
Subject: Re: [PATCH net] tcp: properly terminate timers for kernel sockets

On Fri, 22 Mar 2024 13:57:32 +0000 Eric Dumazet wrote:
> +	if (!sk->sk_net_refcnt)
> +		inet_csk_clear_xmit_timers_sync(sk);

The thought that we should clear or poison sk_net at this point
(whether sk->sk_net_refcnt or not) keeps coming back to me.
If we don't guarantee the pointer is valid - to make it easier
for syzbot to catch invalid accesses?