netdev - Re: [PATCH net] ice: Fix freeing uninitialized pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1655b591-1259-4d71-8f93-e840b1ccc22e@moroto.mountain>
Date: Fri, 22 Mar 2024 08:30:26 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Julia Lawall <Julia.Lawall@...ia.fr>
Cc: Markus Elfring <Markus.Elfring@....de>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	kernel-janitors@...r.kernel.org, netdev@...r.kernel.org,
	intel-wired-lan@...ts.osuosl.org,
	Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Tony Nguyen <anthony.l.nguyen@...el.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Alexander Lobakin <aleksander.lobakin@...el.com>,
	David Laight <David.Laight@...lab.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Jiri Pirko <jiri@...nulli.us>, Jonathan Cameron <jic23@...nel.org>,
	Kees Cook <keescook@...omium.org>,
	Lukasz Czapnik <lukasz.czapnik@...el.com>,
	Paolo Abeni <pabeni@...hat.com>,
	Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net] ice: Fix freeing uninitialized pointers

On Thu, Mar 21, 2024 at 04:20:09PM -0400, Julia Lawall wrote:
> Does one prefer an initialization of null at the top of the function
> or an initialization to a meaningful value in the middle of the
> function?

I prefer at the top, but it will be interesting to see where the
consensus is.  Kent Overstreet has said we should move away from
declarations at the top generally.  I don't know if anyone else agrees
with him though.

regards,
dan carpenter