netdev - Re: [PATCH net-next v3 06/12] net: ethernet: oa_tc6: implement internal PHY initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03e81cee-7f23-45c4-9a2d-343d13a1c59c@microchip.com>
Date: Fri, 22 Mar 2024 05:50:55 +0000
From: <Parthiban.Veerasooran@...rochip.com>
To: <Selvamani.Rajagopal@...emi.com>
CC: <UNGLinuxDriver@...rochip.com>, <Thorsten.Kummermehr@...rochip.com>,
	<Pier.Beruto@...emi.com>, <Nicolas.Ferre@...rochip.com>,
	<benjamin.bigler@...nformulastudent.ch>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<horms@...nel.org>, <saeedm@...dia.com>, <anthony.l.nguyen@...el.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <andrew@...n.ch>,
	<corbet@....net>, <linux-doc@...r.kernel.org>, <robh+dt@...nel.org>,
	<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
	<devicetree@...r.kernel.org>, <Horatiu.Vultur@...rochip.com>,
	<ruanjinjie@...wei.com>, <Steen.Hegelund@...rochip.com>,
	<vladimir.oltean@....com>
Subject: Re: [PATCH net-next v3 06/12] net: ethernet: oa_tc6: implement
 internal PHY initialization

On 22/03/24 12:19 am, Selvamani Rajagopal wrote:
> [Some people who received this message don't often get email from selvamani.rajagopal@...emi.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
>> +static int oa_tc6_mdiobus_register(struct oa_tc6 *tc6) {
>> +     int ret;
>> +
>> +     tc6->mdiobus = mdiobus_alloc();
>> +     if (!tc6->mdiobus) {
>> +             netdev_err(tc6->netdev, "MDIO bus alloc failed\n");
>> +             return -ENODEV;
>> +     }
> 
> Shouldn't it be appropriate to return -ENOMEM here?
Yes, will change it in the next version.

Best regards,
Parthiban V
> 
>> +
>> +     tc6->mdiobus->priv = tc6;
>> +     tc6->mdiobus->read = oa_tc6_mdiobus_direct_read;
>> +     tc6->mdiobus->write = oa_tc6_mdiobus_direct_write;
>> +     tc6->mdiobus->name = "oa-tc6-mdiobus";
>> +     tc6->mdiobus->parent = tc6->dev;
>> +
>