netdev - Re: [PATCH net v2] nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93c09c90-a4d0-44d6-99cb-34bd0bcffe14@linaro.org>
Date: Fri, 22 Mar 2024 07:14:40 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Ryosuke Yasuoka <ryasuoka@...hat.com>, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 jeremy@...ine.org
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 syoshida@...hat.com, syzbot+7ea9413ea6749baf5574@...kaller.appspotmail.com,
 syzbot+29b5ca705d2e0f4a44d2@...kaller.appspotmail.com
Subject: Re: [PATCH net v2] nfc: nci: Fix uninit-value in nci_dev_up and
 nci_ntf_packet

On 20/03/2024 01:54, Ryosuke Yasuoka wrote:
> syzbot reported the following uninit-value access issue [1][2]:
> 
> nci_rx_work() parses and processes received packet. When the payload
> length is zero, each message type handler reads uninitialized payload
> and KMSAN detects this issue. The receipt of a packet with a zero-size
> payload is considered unexpected, and therefore, such packets should be
> silently discarded.
> 
> This patch resolved this issue by checking payload size before calling
> each message type handler codes.
> 
> Fixes: 6a2968aaf50c ("NFC: basic NCI protocol implementation")
> Reported-and-tested-by: syzbot+7ea9413ea6749baf5574@...kaller.appspotmail.com
> Reported-and-tested-by: syzbot+29b5ca705d2e0f4a44d2@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=7ea9413ea6749baf5574 [1]
> Closes: https://syzkaller.appspot.com/bug?extid=29b5ca705d2e0f4a44d2 [2]
> Signed-off-by: Ryosuke Yasuoka <ryasuoka@...hat.com>
> ---
> 
> v2
> - Fix typo in commit message
> - Remove Call Trace from commit message that syzbot reported. Make it
>   shorter than the previous version.
> - Check the payload length in earlier code path. And it can address
>   another reported syzbot bug too. [2]

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof