netdev - Re: [PATCH net-next v3 12/12] dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3c5d217-a5e3-4957-884c-02e8c10aba9d@microchip.com>
Date: Fri, 22 Mar 2024 08:28:38 +0000
From: <Parthiban.Veerasooran@...rochip.com>
To: <krzysztof.kozlowski@...aro.org>, <conor@...nel.org>
CC: <andrew@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <horms@...nel.org>,
	<saeedm@...dia.com>, <anthony.l.nguyen@...el.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <corbet@....net>,
	<linux-doc@...r.kernel.org>, <robh+dt@...nel.org>,
	<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
	<devicetree@...r.kernel.org>, <Horatiu.Vultur@...rochip.com>,
	<ruanjinjie@...wei.com>, <Steen.Hegelund@...rochip.com>,
	<vladimir.oltean@....com>, <UNGLinuxDriver@...rochip.com>,
	<Thorsten.Kummermehr@...rochip.com>, <Pier.Beruto@...emi.com>,
	<Selvamani.Rajagopal@...emi.com>, <Nicolas.Ferre@...rochip.com>,
	<benjamin.bigler@...nformulastudent.ch>
Subject: Re: [PATCH net-next v3 12/12] dt-bindings: net: add Microchip's
 LAN865X 10BASE-T1S MACPHY

Hi Krzysztof,

On 22/03/24 12:33 pm, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 22/03/2024 07:25, Parthiban.Veerasooran@...rochip.com wrote:
>>>> properties:
>>>>      compatible:
>>>>        oneOf:
>>>>          - items:
>>>>              - const: microchip,lan8651
>>>>              - const: microchip,lan8650
>>> No, this is not right either. You need to also allow the lan8650 on its
>>> own. All you had to do with the original items list was flip the order
>>> of the lan8650 and lan8651.
>> Ah ok, now I understand this. Then it is supposed to be like below,
>>
>> properties:
>>
>>     compatible:
>>
>>       oneOf:
>>
>>         - const: microchip,lan8650
>>
>>         - items:
>>
>>             - const: microchip,lan8651
>>
>>             - const: microchip,lan8650
>>
>> Executed dt_binding_check with the above update and it was successful.
>> Hope this is OK?
> 
> This is the third time you ask us. None of the previous cases were
> actually tested. Maybe this one was, maybe not. I assume the latter.
> 
> First, test your code.
As I mentioned in the previous email itself, I tested this case and the 
previous case both in my RPI 4 setup before replying to the comment. The 
question I ask is to check whether the person who comments is OK with 
the changes or not. Didn't you see the attachments in my previous email 
which I used in my RPI 4 dts setup for my testing? if not I can forward 
it again.

Best regards,
Parthiban V
> 
> Best regards,
> Krzysztof
>