netdev - Re: ice: Fix freeing uninitialized pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5412e9e1-2470-497a-a879-d28e6039be15@web.de>
Date: Fri, 22 Mar 2024 09:48:27 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Julia Lawall <Julia.Lawall@...ia.fr>, kernel-janitors@...r.kernel.org,
 netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Dan Carpenter <dan.carpenter@...aro.org>,
 Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Tony Nguyen <anthony.l.nguyen@...el.com>, LKML
 <linux-kernel@...r.kernel.org>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 David Laight <David.Laight@...lab.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 Jesse Brandeburg <jesse.brandeburg@...el.com>, Jiri Pirko
 <jiri@...nulli.us>, Jonathan Cameron <jic23@...nel.org>,
 Kees Cook <keescook@...omium.org>, Lukasz Czapnik
 <lukasz.czapnik@...el.com>, Paolo Abeni <pabeni@...hat.com>,
 Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>,
 Dan Williams <dan.j.williams@...el.com>
Subject: Re: ice: Fix freeing uninitialized pointers

> Does one prefer an initialization of null at the top of the function

Several developers got used to such a programming approach.

> or an initialization to a meaningful value in the middle of the function ?

Coding style preferences are evolving more with the growing support for
the discussed scope-based resource management (cleanup functions and guards),
aren't they?

Further developers can handle variable definitions at the beginning of
a compound statement (a code block) at least.
Corresponding clarifications will influence the change acceptance for such definitions
without adding extra curly brackets.
Would you like to consider design possibilities with scope reductions?

Regards,
Markus