netdev - Re: Heiner Kallweit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240322104955.60990-1-atlas.yu@canonical.com>
Date: Fri, 22 Mar 2024 18:49:56 +0800
From: Atlas Yu <atlas.yu@...onical.com>
To: hkallweit1@...il.com
Cc: atlas.yu@...onical.com,
	davem@...emloft.net,
	edumazet@...gle.com,
	hau@...ltek.com,
	kuba@...nel.org,
	netdev@...r.kernel.org,
	nic_swsd@...ltek.com,
	pabeni@...hat.com
Subject: Re: Heiner Kallweit

On Fri, Mar 22, 2024 at 6:16 PM Heiner Kallweit <hkallweit1@...il.com> wrote:

> No, this only checks whether DASH is enabled.
> I don't think is redundant, because the original change explicitly mentions that
> DASH fw may impact behavior even if DASH is disabled.

I see, thanks for the clarification.

> I understand that on your test system DASH is disabled. But does your system have
> a DASH fw or not?

I am not familiar with DASH, my system's DASH type is "RTL_DASH_EP", and I have no
idea if it has a DASH firmware or not. I am glad to check it if you tell me how.
My patched r8169 driver and r8168 driver both work well on my system.

> My assumption is that the poll loop is relevant on systems with DASH fw, even if
> DASH is disabled.

I know your concern, but in my case it is wasting 300ms on driver startup. Maybe
we can find a way to avoid this together.