netdev - Re: [PATCH V3 net 2/3] net: hns3: fix kernel crash when devlink reload during pf initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed3f0650-1c27-4daf-9f92-0fe0927acea9@huawei.com>
Date: Mon, 25 Mar 2024 20:51:10 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Jiri Pirko <jiri@...nulli.us>
CC: <shaojijie@...wei.com>, <yisen.zhuang@...wei.com>,
	<salil.mehta@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <michal.kubiak@...el.com>,
	<rkannoth@...vell.com>, <shenjian15@...wei.com>, <wangjie125@...wei.com>,
	<liuyonglong@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 net 2/3] net: hns3: fix kernel crash when devlink
 reload during pf initialization


on 2024/3/19 19:17, Jiri Pirko wrote:
> Mon, Mar 18, 2024 at 02:29:47PM CET, shaojijie@...wei.com wrote:
>> From: Yonglong Liu <liuyonglong@...wei.com>
>>
>> The devlink reload process will access the hardware resources,
>> but the register operation is done before the hardware is initialized.
>> so, if process the devlink reload during initialization, may lead to kernel
>> crash. This patch fixes this by checking whether the NIC is initialized.
> Fix your locking, you should take devl_lock during your init. That would
> disallow reload to race with it.
>
> pw-bot: cr

Thanks，

   We have fixed this in v4.

   Jijie Shao