netdev - Re: kunit alltests runs broken in mainline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c9e1297e2548b363fc93e774c8546e6ebf4efd6.camel@sipsolutions.net>
Date: Mon, 25 Mar 2024 16:29:53 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Mark Brown <broonie@...nel.org>, Brendan Higgins
 <brendanhiggins@...gle.com>,  David Gow <davidgow@...gle.com>, Rae Moar
 <rmoar@...gle.com>
Cc: netdev@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	kunit-dev@...glegroups.com, x86@...nel.org, linux-wireless@...r.kernel.org
Subject: Re: kunit alltests runs broken in mainline

On Mon, 2024-03-25 at 15:21 +0000, Mark Brown wrote:
> Hi,
> 
> Commit 28b3df1fe6ba2cb4 ("kunit: add wireless unit tests") which I can't
> seem to find on lore breaks full kunit runs on non-UML builds and is now
> present in mainline.  If I run:
> 
>    ./tools/testing/kunit/kunit.py run --alltests --cross_compile x86_64-linux-gnu- --arch x86_64
> 
> on a clean tree then I get:
> 
>    [15:09:20] Configuring KUnit Kernel ...
>    Generating .config ...
>    Populating config with:
>    $ make ARCH=x86_64 O=.kunit olddefconfig CROSS_COMPILE=x86_64-linux-gnu-
>    ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config.
>    This is probably due to unsatisfied dependencies.
>    Missing: CONFIG_IWLWIFI=y, CONFIG_WLAN_VENDOR_INTEL=y
> 
> UML works fine, but other real architectures (eg, arm64) seem similarly
> broken.

Hmm, strange.

> I've not looked properly yet, I'm a bit confused given that
> there's not even any dependencies for WLAN_VENDOR_INTEL and it's not
> mentoned in the defconfig.

Well it's in the directory dependencies or something I think, this seems
to help:

--- a/tools/testing/kunit/configs/all_tests.config
+++ b/tools/testing/kunit/configs/all_tests.config
@@ -28,6 +28,8 @@ CONFIG_MCTP_FLOWS=y
 CONFIG_INET=y
 CONFIG_MPTCP=y
 
+CONFIG_NETDEVICES=y
+CONFIG_WLAN=y
 CONFIG_CFG80211=y
 CONFIG_MAC80211=y
 CONFIG_WLAN_VENDOR_INTEL=y


But I'm not sure why ARCH=um is different?

johannes