netdev - Re: [PATCH net-next] net: remove skb_free_datagram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240325190420.GE403975@kernel.org>
Date: Mon, 25 Mar 2024 19:04:20 +0000
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com,
	Jason Xing <kerneljasonxing@...il.com>
Subject: Re: [PATCH net-next] net: remove skb_free_datagram_locked()

On Mon, Mar 25, 2024 at 01:41:55PM +0000, Eric Dumazet wrote:
> Last user of skb_free_datagram_locked() went away in 2016
> with commit 850cbaddb52d ("udp: use it's own memory
> accounting schema").
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reviewed-by: Jason Xing <kerneljasonxing@...il.com>

Not that it really matters, but I think this function had just one last
user until: 4af8b42e5629 ("SUNRPC: Remove dead code in svc_tcp_release_rqst()")

In any case, this looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>