netdev - Re: [PATCH v1 net 1/8] tcp: Fix bind() regression for v6-only wildcard and v4-mapped-v6 non-wildcard addresses.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240325165633.0664c3f8@kernel.org>
Date: Mon, 25 Mar 2024 16:56:33 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, David Ahern
 <dsahern@...nel.org>, Joanne Koong <joannelkoong@...il.com>, Jianguo Wu
 <wujianguo106@....com>, Kuniyuki Iwashima <kuni1840@...il.com>,
 <netdev@...r.kernel.org>
Subject: Re: [PATCH v1 net 1/8] tcp: Fix bind() regression for v6-only
 wildcard and v4-mapped-v6 non-wildcard addresses.

On Mon, 25 Mar 2024 11:19:16 -0700 Kuniyuki Iwashima wrote:
> -	if (sk->sk_family == AF_INET && ipv6_only_sock(sk2))
> +	if (ipv6_only_sock(sk2) &&
> +	    (sk->sk_family == AF_INET || ipv6_addr_v4mapped(&sk->sk_v6_rcv_saddr)))

breaks build for IPV6=n (i.e. TDC):

https://github.com/p4tc-dev/tc-executor/commit/ac16181d7589bdf29c7c3907243e829f6b954570#diff-0042f6af11ac801c4370fb95b8e4f0de734b793c9e23bff936a1bb03c63eb6f0R228
-- 
pw-bot: cr