netdev - Re: [PATCH] net: wan: framer: Add missing static inline qualifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 25 Mar 2024 11:23:07 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Herve Codina <herve.codina@...tlin.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	kernel test robot <lkp@...el.com>, stable@...r.kernel.org
Subject: Re: [PATCH] net: wan: framer: Add missing static inline qualifiers

On Mon, Mar 25, 2024 at 09:25:05AM +0100, Herve Codina wrote:
> Compilation with CONFIG_GENERIC_FRAMER disabled lead to the following
> warnings:
>   framer.h:184:16: warning: no previous prototype for function 'framer_get' [-Wmissing-prototypes]
>   184 | struct framer *framer_get(struct device *dev, const char *con_id)
>   framer.h:184:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>   184 | struct framer *framer_get(struct device *dev, const char *con_id)
>   framer.h:189:6: warning: no previous prototype for function 'framer_put' [-Wmissing-prototypes]
>   189 | void framer_put(struct device *dev, struct framer *framer)
>   framer.h:189:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>   189 | void framer_put(struct device *dev, struct framer *framer)

Always try to minimize the warnings/backtraces/etc to the point. In this case
it's enough to have:

  warning: no previous prototype for function 'framer_get' [-Wmissing-prototypes]
  warning: no previous prototype for function 'framer_put' [-Wmissing-prototypes]

> Add missing 'static inline' qualifiers for these functions.

Code wise looks good,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko