netdev - Re: [PATCH net 1/4] tls: recv: process_rx_list shouldn't use an offset with kvec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240326115856.GP403975@kernel.org>
Date: Tue, 26 Mar 2024 11:58:56 +0000
From: Simon Horman <horms@...nel.org>
To: Sabrina Dubroca <sd@...asysnail.net>
Cc: netdev@...r.kernel.org, Vakul Garg <vakul.garg@....com>,
	Boris Pismenny <borisp@...dia.com>,
	John Fastabend <john.fastabend@...il.com>,
	Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net 1/4] tls: recv: process_rx_list shouldn't use an
 offset with kvec

On Mon, Mar 25, 2024 at 04:56:45PM +0100, Sabrina Dubroca wrote:
> Only MSG_PEEK needs to copy from an offset during the final
> process_rx_list call, because the bytes we copied at the beginning of
> tls_sw_recvmsg were left on the rx_list. In the KVEC case, we removed
> data from the rx_list as we were copying it, so there's no need to use
> an offset, just like in the normal case.
> 
> Fixes: 692d7b5d1f91 ("tls: Fix recvmsg() to be able to peek across multiple records")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Reviewed-by: Simon Horman <horms@...nel.org>