netdev - Re: [PATCH net-next v8 08/11] net: stmmac: dwmac-loongson: Fix MAC speed for GNET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <144b4703-4917-4350-bffd-e5c9d918785c@loongson.cn>
Date: Tue, 26 Mar 2024 20:32:27 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Andrew Lunn <andrew@...n.ch>,
 "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Serge Semin <fancer.lancer@...il.com>, hkallweit1@...il.com,
 peppe.cavallaro@...com, alexandre.torgue@...s.st.com, joabreu@...opsys.com,
 Jose.Abreu@...opsys.com, chenhuacai@...ngson.cn, guyinggang@...ngson.cn,
 netdev@...r.kernel.org, chris.chenfeiyang@...il.com
Subject: Re: [PATCH net-next v8 08/11] net: stmmac: dwmac-loongson: Fix MAC
 speed for GNET

Hi Andrew, Serge and Russell,

在 2024/3/21 23:38, Andrew Lunn 写道:
>> However, because stmmac uses phylink, we should be adding phylink
>> interfaces that forward to phylib to avoid the layering violation.
> Yes.
>
> Maybe just call phylink_ethtool_nway_reset()?  Just depends if the

Nice! It works.


In fact, after repeated testing, my previous code did not fix all 
issues, such

as network unavailability when switching from 1000M to 100M(physical).


But your method is perfect!



Thanks,

Yanteng

> additional phylink_pcs_an_restart(pl) will mess things up for this
> device.
>
>        Andrew