netdev - Re: [PATCH net-next v2 3/3] genetlink: remove linux/genetlink.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240325185851.1c876761@kernel.org>
Date: Mon, 25 Mar 2024 18:58:51 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, dw@...idwei.uk, jiri@...nulli.us, Sven Eckelmann
 <sven@...fation.org>, Jason@...c4.com, mareklindner@...mailbox.ch,
 sw@...onwunderlich.de, a@...table.cc, pshelar@....org,
 wireguard@...ts.zx2c4.com, dev@...nvswitch.org
Subject: Re: [PATCH net-next v2 3/3] genetlink: remove linux/genetlink.h

On Mon, 25 Mar 2024 19:45:05 +0200 Andy Shevchenko wrote:
> > +/* Non-parallel generic netlink requests are serialized by a global lock.  */  
> 
> While at it, maybe drop extra space? (I noticed it was originally like this.

Fair, I'll post v3.

> > +#define MODULE_ALIAS_GENL_FAMILY(family) \
> > + MODULE_ALIAS_NET_PF_PROTO_NAME(PF_NETLINK, NETLINK_GENERIC, "-family-" family)  
> 
> I would still make this TAB indented.

That one I'd prefer to keep. Coin toss between going over 80 chars
and having someone atypical indent.
-- 
pw-bot: cr