netdev - Re: [PATCH net] selftests: netdevsim: set test timeout to 10 minutes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240326141348.GV403975@kernel.org>
Date: Tue, 26 Mar 2024 14:13:48 +0000
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, shuah@...nel.org, dw@...idwei.uk,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net] selftests: netdevsim: set test timeout to 10 minutes

On Mon, Mar 25, 2024 at 08:56:11AM -0700, Jakub Kicinski wrote:
> The longest running netdevsim test, nexthop.sh, currently takes
> 5 min to finish. Around 260s to be exact, and 310s on a debug kernel.
> The default timeout in selftest is 45sec, so we need an explicit
> config. Give ourselves some headroom and use 10min.
> 
> Commit under Fixes isn't really to "blame" but prior to that
> netdevsim tests weren't integrated with kselftest infra
> so blaming the tests themselves doesn't seem right, either.
> 
> Fixes: 8ff25dac88f6 ("netdevsim: add Makefile for selftests")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>