netdev - RE: [PATCH net-next v4 3/3] ice: fold ice_ptp_read_time into ice_ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <BY3PR18MB470764790C39F0CA7BABAB0DA0352@BY3PR18MB4707.namprd18.prod.outlook.com>
Date: Tue, 26 Mar 2024 14:46:13 +0000
From: Sai Krishna Gajula <saikrishnag@...vell.com>
To: Michal Schmidt <mschmidt@...hat.com>,
        "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Tony Nguyen
	<anthony.l.nguyen@...el.com>,
        Richard Cochran <richardcochran@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jacob Keller
	<jacob.e.keller@...el.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Arkadiusz
 Kubalewski <arkadiusz.kubalewski@...el.com>,
        Karol Kolacinski
	<karol.kolacinski@...el.com>,
        Marcin Szycik <marcin.szycik@...ux.intel.com>,
        Przemek Kitszel <przemyslaw.kitszel@...el.com>,
        "Temerkhanov, Sergey"
	<sergey.temerkhanov@...el.com>
Subject: RE: [PATCH net-next v4 3/3] ice: fold ice_ptp_read_time into
 ice_ptp_gettimex64


> -----Original Message-----
> From: Michal Schmidt <mschmidt@...hat.com>
> Sent: Tuesday, March 26, 2024 4:51 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>; Tony Nguyen
> <anthony.l.nguyen@...el.com>; Richard Cochran
> <richardcochran@...il.com>; netdev@...r.kernel.org; Jacob Keller
> <jacob.e.keller@...el.com>; Jiri Pirko <jiri@...nulli.us>; Arkadiusz Kubalewski
> <arkadiusz.kubalewski@...el.com>; Karol Kolacinski
> <karol.kolacinski@...el.com>; Marcin Szycik <marcin.szycik@...ux.intel.com>;
> Przemek Kitszel <przemyslaw.kitszel@...el.com>; Temerkhanov, Sergey
> <sergey.temerkhanov@...el.com>
> Subject: [PATCH net-next v4 3/3] ice: fold ice_ptp_read_time into
> ice_ptp_gettimex64
>  
> This is a cleanup. It is unnecessary to have this function just to call another
> function.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_ptp.c | 25 +++---------------------
>  1 file changed, 3 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c
> b/drivers/net/ethernet/intel/ice/ice_ptp.c
> index 0875f37add78..0f17fc1181d2 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ptp.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ptp.c
> @@ -1166,26 +1166,6 @@ static void ice_ptp_reset_cached_phctime(struct
> ice_pf *pf)
>  	ice_ptp_mark_tx_tracker_stale(&pf->ptp.port.tx);
>  }
> 
> -/**
> - * ice_ptp_read_time - Read the time from the device
> - * @pf: Board private structure
> - * @ts: timespec structure to hold the current time value
> - * @sts: Optional parameter for holding a pair of system timestamps from
> - *       the system clock. Will be ignored if NULL is given.
> - *
> - * This function reads the source clock registers and stores them in a
> timespec.
> - * However, since the registers are 64 bits of nanoseconds, we must convert
> the
> - * result to a timespec before we can return.
> - */
> -static void
> -ice_ptp_read_time(struct ice_pf *pf, struct timespec64 *ts,
> -		  struct ptp_system_timestamp *sts)
> -{
> -	u64 time_ns = ice_ptp_read_src_clk_reg(pf, sts);
> -
> -	*ts = ns_to_timespec64(time_ns);
> -}
> -
>  /**
>   * ice_ptp_write_init - Set PHC time to provided value
>   * @pf: Board private structure
> @@ -1926,9 +1906,10 @@ ice_ptp_gettimex64(struct ptp_clock_info *info,
> struct timespec64 *ts,
>  		   struct ptp_system_timestamp *sts)
>  {
>  	struct ice_pf *pf = ptp_info_to_pf(info);
> +	u64 time_ns;
> 
> -	ice_ptp_read_time(pf, ts, sts);
> -
> +	time_ns = ice_ptp_read_src_clk_reg(pf, sts);
> +	*ts = ns_to_timespec64(time_ns);	
>  	return 0;
>  }
> 
> --
> 2.43.2
> 
Reviewed-by: Sai Krishna <saikrishnag@...vell.com