netdev - [PATCH] net/rds: fix possible cp null dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240326153132.55580-1-mngyadam@amazon.com>
Date: Tue, 26 Mar 2024 16:31:33 +0100
From: Mahmoud Adam <mngyadam@...zon.com>
To: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <eadavis@...com>, <netdev@...r.kernel.org>
Subject: [PATCH] net/rds: fix possible cp null dereference

cp might be null, calling cp->cp_conn would produce null dereference

Fixes: c055fc00c07b ("net/rds: fix WARNING in rds_conn_connect_if_down")
Cc: stable@...r.kernel.org # v4.19+
Signed-off-by: Mahmoud Adam <mngyadam@...zon.com>
---
This was found by our coverity bot, and only tested by building the kernel.
also was reported here: https://lore.kernel.org/all/202403071132.37BBF46E@keescook/

 net/rds/rdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index a4e3c5de998b..00dbcd4d28e6 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -302,7 +302,7 @@ static int __rds_rdma_map(struct rds_sock *rs, struct rds_get_mr_args *args,
 		}
 		ret = PTR_ERR(trans_private);
 		/* Trigger connection so that its ready for the next retry */
-		if (ret == -ENODEV)
+		if (ret == -ENODEV && cp)
 			rds_conn_connect_if_down(cp->cp_conn);
 		goto out;
 	}
--
2.40.1