netdev - Re: [PATCH net-next v2 03/22] ovpn: add basic netlink support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e2df22d-ffaf-4457-8d6f-079c1dcf9bec@openvpn.net>
Date: Tue, 26 Mar 2024 22:39:50 +0100
From: Antonio Quartulli <antonio@...nvpn.net>
To: Esben Haabendal <esben@...nix.com>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
 Sergey Ryazanov <ryazanov.s.a@...il.com>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next v2 03/22] ovpn: add basic netlink support

On 26/03/2024 12:43, Esben Haabendal wrote:
> Antonio Quartulli <antonio@...nvpn.net> writes:
> 
>> diff --git a/drivers/net/ovpn/main.c b/drivers/net/ovpn/main.c
>> index 25964eb89aac..3769f99cfe6f 100644
>> --- a/drivers/net/ovpn/main.c
>> +++ b/drivers/net/ovpn/main.c
>> @@ -101,12 +104,23 @@ static int __init ovpn_init(void)
>>   		return err;
>>   	}
>>   
>> +	err = ovpn_nl_register();
>> +	if (err) {
>> +		pr_err("ovpn: can't register netlink family: %d\n", err);
>> +		goto unreg_netdev;
>> +	}
>> +
>>   	return 0;
>> +
>> +unreg_netdev:
>> +	unregister_netdevice_notifier(&ovpn_netdev_notifier);
>> +	return err;
>>   }
>>   
>>   static __exit void ovpn_cleanup(void)
>>   {
>>   	unregister_netdevice_notifier(&ovpn_netdev_notifier);
>> +	ovpn_nl_unregister();
> 
> Any good reason for not using reverse order from ovpn_init() here?

not really.
Actually I also prefer uninit in reverse order compared to init.

Will fix this, thanks!

> 
>>   }
> 
> /Esben

-- 
Antonio Quartulli
OpenVPN Inc.