netdev - Re: [PATCH net v5] net: txgbe: fix i2c dev name cannot match clkdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6620d1c1-4178-413e-b090-dd2a9ba9abf3@gmail.com>
Date: Wed, 27 Mar 2024 05:40:10 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: duanqiangwen@...-swift.com, 'Jiri Pirko' <jiri@...nulli.us>
Cc: netdev@...r.kernel.org, jiawenwu@...stnetic.com,
 mengyuanlou@...-swift.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, maciej.fijalkowski@...el.com,
 andrew@...n.ch, wangxiongfeng2@...wei.com, linux-kernel@...r.kernel.org,
 michal.kubiak@...el.com
Subject: Re: [PATCH net v5] net: txgbe: fix i2c dev name cannot match clkdev



On 3/26/2024 6:29 PM, duanqiangwen@...-swift.com wrote:
>> -----Original Message-----
>> From: Jiri Pirko <jiri@...nulli.us>
>> Sent: 2024年3月22日 16:12
>> To: Duanqiang Wen <duanqiangwen@...-swift.com>
>> Cc: netdev@...r.kernel.org; jiawenwu@...stnetic.com;
>> mengyuanlou@...-swift.com; davem@...emloft.net;
>> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com;
>> maciej.fijalkowski@...el.com; andrew@...n.ch;
>> wangxiongfeng2@...wei.com; linux-kernel@...r.kernel.org;
>> michal.kubiak@...el.com
>> Subject: Re: [PATCH net v5] net: txgbe: fix i2c dev name cannot match
> clkdev
>>
>> Fri, Mar 22, 2024 at 09:04:16AM CET, duanqiangwen@...-swift.com wrote:
>>> txgbe clkdev shortened clk_name, so i2c_dev info_name also need to
>>> shorten. Otherwise, i2c_dev cannot initialize clock.
>>>
>>> Change log:
>>> v4-v5: address comments:
>>> 	Jiri Pirko:
>>> 	Well, since it is used in txgbe_phy.c, it should be probably
>>> 	rather defined locally in txgbe_phy.c.
>>
>> Did you read Florian's comment? Please do.
>>
>> pw-bot: cr
>>
> 
> I replied to Florian:
> " I want to shorten "i2c_desginware" to "i2c_dw" in txgbe driver, so other
> drivers which use "i2c_designware" need another patch to use a define. "
> 
> He hasn't replied to me for several days, what should I do next?

You emailed me directly rather than do a reply-all and have the mailing 
list copied. At any rate, you are only changing your internal clock 
name, so my suggestion to standardize the 'i2c_designware' string beyond 
your driver did not really make sense.

With that:

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>

Thanks!
-- 
Florian