netdev - Re: [PATCH net-next v8 08/11] net: stmmac: dwmac-loongson: Fix MAC speed for GNET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <234e3ee5-ff39-4691-943d-c46dbdfde73b@lunn.ch>
Date: Wed, 27 Mar 2024 13:47:44 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Yanteng Si <siyanteng@...ngson.cn>
Cc: Serge Semin <fancer.lancer@...il.com>, hkallweit1@...il.com,
	peppe.cavallaro@...com, alexandre.torgue@...s.st.com,
	joabreu@...opsys.com, Jose.Abreu@...opsys.com,
	chenhuacai@...ngson.cn, linux@...linux.org.uk,
	guyinggang@...ngson.cn, netdev@...r.kernel.org,
	chris.chenfeiyang@...il.com
Subject: Re: [PATCH net-next v8 08/11] net: stmmac: dwmac-loongson: Fix MAC
 speed for GNET

On Wed, Mar 27, 2024 at 10:41:57AM +0800, Yanteng Si wrote:
> 
> 在 2024/3/26 20:21, Andrew Lunn 写道:
> > On Tue, Mar 26, 2024 at 08:02:55PM +0800, Yanteng Si wrote:
> > > 在 2024/3/21 23:02, Andrew Lunn 写道:
> > > > > When switching speeds (from 100M to 1000M), the phy cannot output clocks,
> > > > > 
> > > > > resulting in the unavailability of the network card.  At this time, a reset
> > > > > of the
> > > > > 
> > > > > phy is required.
> > > > reset, or restart of autoneg?
> > > reset.
> > If you need a reset, why are you asking it to restart auto-neg?
> Autoneg was discussed in patch v1, but we may have misunderstood the
> description from our hardware engineers at the time. The root cause is that
> there is an error in the connection between the MAC and PHY. After repeated
> tests, we have found that
> 
> auto-negcannot solve all problems and can only be reset. Thanks, Yanteng
 
So calling phylink_ethtool_nway_reset() does not fix your problem, and
you need some other fix.

    Andrew

---
pw-bot: cr