netdev - RE: [EXTERNAL] [PATCH 4/9] mlx5: avoid truncating error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <CO1PR18MB4666C0CAAD3DDD40692BDC82A1342@CO1PR18MB4666.namprd18.prod.outlook.com>
Date: Wed, 27 Mar 2024 14:08:59 +0000
From: Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
To: Arnd Bergmann <arnd@...nel.org>,
        "llvm@...ts.linux.dev"
	<llvm@...ts.linux.dev>,
        Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky
	<leon@...nel.org>
CC: Arnd Bergmann <arnd@...db.de>, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo
 Abeni <pabeni@...hat.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick
 Desaulniers <ndesaulniers@...gle.com>,
        Bill Wendling <morbo@...gle.com>,
        Justin Stitt <justinstitt@...gle.com>, Vlad Buslov <vladbu@...dia.com>,
        Roi
 Dayan <roid@...dia.com>, Maor Dickman <maord@...dia.com>,
        Gal Pressman
	<gal@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXTERNAL] [PATCH 4/9] mlx5: avoid truncating error message

Hi,

>-----Original Message-----
>From: Arnd Bergmann <arnd@...nel.org>
>Sent: Wednesday, March 27, 2024 4:08 AM
>To: llvm@...ts.linux.dev; Saeed Mahameed <saeedm@...dia.com>; Leon
>Romanovsky <leon@...nel.org>
>Cc: Arnd Bergmann <arnd@...db.de>; David S. Miller <davem@...emloft.net>;
>Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
>Abeni <pabeni@...hat.com>; Nathan Chancellor <nathan@...nel.org>; Nick
>Desaulniers <ndesaulniers@...gle.com>; Bill Wendling <morbo@...gle.com>;
>Justin Stitt <justinstitt@...gle.com>; Vlad Buslov <vladbu@...dia.com>; Roi
>Dayan <roid@...dia.com>; Maor Dickman <maord@...dia.com>; Gal Pressman
><gal@...dia.com>; netdev@...r.kernel.org; linux-rdma@...r.kernel.org; linux-
>kernel@...r.kernel.org
>Subject: [PATCH 4/9] mlx5: avoid truncating error message
>
>From: Arnd Bergmann <arnd@...db.de>
>
>clang warns that one error message is too long for its destination buffer:
>
>drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c:1876:4: error: 'snprintf'
>will always be truncated; specified size is 80, but format string expands to at least
>94 [-Werror,-Wformat-truncation-non-kprintf]
>
>Reword it to be a bit shorter so it always fits.
>
>Fixes: 70f0302b3f20 ("net/mlx5: Bridge, implement mdb offload")
>Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Subbaraya Sundeep <sbhatta@...vell.com>

Thanks,
Sundeep


>---
> drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c
>b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c
>index 1b9bc32efd6f..c5ea1d1d2b03 100644
>--- a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c
>+++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c
>@@ -1874,7 +1874,7 @@ int mlx5_esw_bridge_port_mdb_add(struct net_device
>*dev, u16 vport_num, u16 esw_
> 				 "Failed to lookup bridge port vlan metadata to
>create MDB (MAC=%pM,vid=%u,vport=%u)\n",
> 				 addr, vid, vport_num);
> 			NL_SET_ERR_MSG_FMT_MOD(extack,
>-					       "Failed to lookup bridge port vlan
>metadata to create MDB (MAC=%pM,vid=%u,vport=%u)\n",
>+					       "Failed to lookup vlan metadata for
>MDB (MAC=%pM,vid=%u,vport=%u)\n",
> 					       addr, vid, vport_num);
> 			return -EINVAL;
> 		}
>--
>2.39.2
>