netdev - Re: [PATCH net-next 3/4] net: team: use policy generated by YAML spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240326204041.281cdd38@kernel.org>
Date: Tue, 26 Mar 2024 20:40:41 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Donald
 Hunter <donald.hunter@...il.com>, Jiri Pirko <jiri@...nulli.us>, Jacob
 Keller <jacob.e.keller@...el.com>, Stanislav Fomichev <sdf@...gle.com>
Subject: Re: [PATCH net-next 3/4] net: team: use policy generated by YAML
 spec

On Tue, 26 Mar 2024 11:30:03 +0800 Hangbin Liu wrote:
>  
> -static int team_nl_cmd_port_list_get(struct sk_buff *skb,
> +int team_nl_port_list_get_doit(struct sk_buff *skb,
>  				     struct genl_info *info)

nit: please adjust the indent of the continuation line

> +/* Global operation policy for team */
> +const struct nla_policy team_nl_policy[TEAM_ATTR_LIST_OPTION + 1] = {

You need to adjust max_attr in the family to be
ARRAY_SIZE(team_nl_policy), it's no longer TEAM_ATTR_MAX.
-- 
pw-bot: cr