netdev - Re: [PATCH 18/22] nvdimm: virtio_pmem: drop owner assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2757205c-8a58-4619-bed1-d511812d5a18@intel.com>
Date: Wed, 27 Mar 2024 08:52:35 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 "Michael S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>,
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Richard Weinberger <richard@....at>,
 Anton Ivanov <anton.ivanov@...bridgegreys.com>,
 Johannes Berg <johannes@...solutions.net>,
 Paolo Bonzini <pbonzini@...hat.com>, Stefan Hajnoczi <stefanha@...hat.com>,
 Jens Axboe <axboe@...nel.dk>, Marcel Holtmann <marcel@...tmann.org>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 Olivia Mackall <olivia@...enic.com>, Herbert Xu
 <herbert@...dor.apana.org.au>, Amit Shah <amit@...nel.org>,
 Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Gonglei <arei.gonglei@...wei.com>, "David S. Miller" <davem@...emloft.net>,
 Viresh Kumar <vireshk@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>, David Airlie <airlied@...hat.com>,
 Gerd Hoffmann <kraxel@...hat.com>,
 Gurchetan Singh <gurchetansingh@...omium.org>, Chia-I Wu
 <olvaffe@...il.com>, Jean-Philippe Brucker <jean-philippe@...aro.org>,
 Joerg Roedel <joro@...tes.org>, Alexander Graf <graf@...zon.com>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Eric Van Hensbergen <ericvh@...nel.org>,
 Latchesar Ionkov <lucho@...kov.net>,
 Dominique Martinet <asmadeus@...ewreck.org>,
 Christian Schoenebeck <linux_oss@...debyte.com>,
 Stefano Garzarella <sgarzare@...hat.com>, Kalle Valo <kvalo@...nel.org>,
 Dan Williams <dan.j.williams@...el.com>,
 Vishal Verma <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>,
 Pankaj Gupta <pankaj.gupta.linux@...il.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Mathieu Poirier <mathieu.poirier@...aro.org>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Vivek Goyal <vgoyal@...hat.com>, Miklos Szeredi <miklos@...redi.hu>,
 Anton Yakovlev <anton.yakovlev@...nsynergy.com>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc: virtualization@...ts.linux.dev, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-um@...ts.infradead.org,
 linux-block@...r.kernel.org, linux-bluetooth@...r.kernel.org,
 linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-gpio@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 iommu@...ts.linux.dev, netdev@...r.kernel.org, v9fs@...ts.linux.dev,
 kvm@...r.kernel.org, linux-wireless@...r.kernel.org, nvdimm@...ts.linux.dev,
 linux-remoteproc@...r.kernel.org, linux-scsi@...r.kernel.org,
 linux-fsdevel@...r.kernel.org, alsa-devel@...a-project.org,
 linux-sound@...r.kernel.org
Subject: Re: [PATCH 18/22] nvdimm: virtio_pmem: drop owner assignment

On 3/27/24 5:41 AM, Krzysztof Kozlowski wrote:
> virtio core already sets the .owner, so driver does not need to.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Acked-by: Dave Jiang <dave.jiang@...el.com>
> 
> ---
> 
> Depends on the first patch.
> ---
>  drivers/nvdimm/virtio_pmem.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/nvdimm/virtio_pmem.c b/drivers/nvdimm/virtio_pmem.c
> index 4ceced5cefcf..c9b97aeabf85 100644
> --- a/drivers/nvdimm/virtio_pmem.c
> +++ b/drivers/nvdimm/virtio_pmem.c
> @@ -151,7 +151,6 @@ static struct virtio_driver virtio_pmem_driver = {
>  	.feature_table		= features,
>  	.feature_table_size	= ARRAY_SIZE(features),
>  	.driver.name		= KBUILD_MODNAME,
> -	.driver.owner		= THIS_MODULE,
>  	.id_table		= id_table,
>  	.validate		= virtio_pmem_validate,
>  	.probe			= virtio_pmem_probe,
>