netdev - RE: [EXTERNAL] Re: [PATCH net-next v2] tg3: Remove residual error handling in tg3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <MWHPR1801MB1918E81A947684F6B86A1A41D3342@MWHPR1801MB1918.namprd18.prod.outlook.com>
Date: Wed, 27 Mar 2024 05:13:03 +0000
From: Ratheesh Kannoth <rkannoth@...vell.com>
To: Michael Chan <michael.chan@...adcom.com>, Jakub Kicinski <kuba@...nel.org>
CC: Nikita Kiryushin <kiryushin@...ud.ru>, Michael Chan <mchan@...adcom.com>,
        Pavan Chebbi <pavan.chebbi@...adcom.com>,
        "David S. Miller"
	<davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
	<pabeni@...hat.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lvc-project@...uxtesting.org" <lvc-project@...uxtesting.org>
Subject: RE: [EXTERNAL] Re: [PATCH net-next v2] tg3: Remove residual error
 handling in tg3_suspend

> From: Michael Chan <michael.chan@...adcom.com>
> Sent: Wednesday, March 27, 2024 10:39 AM
> To: Jakub Kicinski <kuba@...nel.org>
> Cc: Ratheesh Kannoth <rkannoth@...vell.com>; Nikita Kiryushin
> <kiryushin@...ud.ru>; Michael Chan <mchan@...adcom.com>; Pavan
> Chebbi <pavan.chebbi@...adcom.com>; David S. Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Paolo
> Abeni <pabeni@...hat.com>; Rafael J. Wysocki <rjw@...ysocki.net>;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; lvc-
> project@...uxtesting.org
> Subject: [EXTERNAL] Re: [PATCH net-next v2] tg3: Remove residual error
> handling in tg3_suspend
> 
> Prioritize security for external emails: Confirm sender and content safety
> before clicking links or opening attachments
> 
> ----------------------------------------------------------------------
> On Tue, Mar 26, 2024 at 8:24 PM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > On Wed, 27 Mar 2024 08:14:30 +0530 Ratheesh Kannoth wrote:
> > > > @@ -18090,7 +18090,6 @@ static int tg3_suspend(struct device
> *device)
> > > >  {
> > > Please address Michael Chan's comment to make this function return type
> to "void"
> > > instead of "int"
> >
> > It's used as a callback in SIMPLE_DEV_PM_OPS(), how would that work?
> 
> It won't work.  I only requested to change tg3_power_down_prepare() to
> void and it was done in v2:
> 
> https://lore.kernel.org/netdev/CACKFLinzJjqe0j4OFkcCV+FyH0JiUpnj3j2azZk
> GaC9jfvFXrQ@...l.gmail.com/
Got it. Thanks.