netdev - Re: [PATCH net-next 7/8] net/mlx5e: XDP, Fix an inconsistent comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240328111755.GZ403975@kernel.org>
Date: Thu, 28 Mar 2024 11:17:55 +0000
From: Simon Horman <horms@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
	Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>,
	Leon Romanovsky <leonro@...dia.com>,
	Carolina Jubran <cjubran@...dia.com>
Subject: Re: [PATCH net-next 7/8] net/mlx5e: XDP, Fix an inconsistent comment

On Wed, Mar 27, 2024 at 12:20:21AM +0200, Tariq Toukan wrote:
> From: Carolina Jubran <cjubran@...dia.com>
> 
> Since sinfo is no longer passed as an argument to
> mlx5e_xmit_xdp_frame(), the comment is inconsistent.
> 
> check_result must be zero when the packet is fragmented.
> 
> Signed-off-by: Carolina Jubran <cjubran@...dia.com>
> Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>

Hi Carolina and Tariq,

This looks good to me, but if there is a need to repost for some
other reason perhaps it would be worth mentioning that the commit
where the sinfo parameter was removed from mlx5e_xmit_xdp_frame()
was:

eb9b9fdcafe2 ("net/mlx5e: Introduce extended version for mlx5e_xmit_data")

That notwithstanding,

Reviewed-by: Simon Horman <horms@...nel.org>