netdev - Re: [PATCH net-next 6/8] net/mlx5e: debugfs, Add reset option for command interface stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240328112045.GF403975@kernel.org>
Date: Thu, 28 Mar 2024 11:20:45 +0000
From: Simon Horman <horms@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
	Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>,
	Leon Romanovsky <leonro@...dia.com>
Subject: Re: [PATCH net-next 6/8] net/mlx5e: debugfs, Add reset option for
 command interface stats

On Wed, Mar 27, 2024 at 12:20:20AM +0200, Tariq Toukan wrote:
> Resetting stats just before some test/debug case allows us to eliminate
> out the impact of previous commands. Useful in particular for the
> average latency calculation.
> 
> The average_write() callback was unreachable, as "average" is a
> read-only file. Extend, rename,  and use it for a newly exposed
> write-only "reset" file.
> 
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>
> Reviewed-by: Saeed Mahameed <saeedm@...dia.com>
> Reviewed-by: Gal Pressman <gal@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>