netdev - Re: [PATCH] ip: Make errors direct to "list" instead of "show"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240327191750.2fa35c98@hermes.local>
Date: Wed, 27 Mar 2024 19:17:50 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Yedaya <yedaya.ka@...il.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] ip: Make errors direct to "list" instead of "show"

On Mon, 25 Mar 2024 23:45:05 +0200
Yedaya <yedaya.ka@...il.com> wrote:

> On Mon, Mar 25, 2024 at 02:19:20PM -0700, Stephen Hemminger wrote:
> > On Mon, 25 Mar 2024 22:48:37 +0200
> > Yedaya Katsman <yedaya.ka@...il.com> wrote:
> >   
> > > The usage text and man pages only have "list" in them, but the errors
> > > when using "ip ila list" and "ip addrlabel list" incorrectly direct to
> > > running the "show" subcommand. Make them consistent by mentioning "list"
> > > instead.
> > > 
> > > Signed-off-by: Yedaya Katsman <yedaya.ka@...il.com>  
> > 
> > That is because ip command treats "list" and "show" the same.
> > Would it be better to do the same in all sub commands?
> >  
> I'm not sure what else you're talking about changing, I couldn't find
> anywhere where a "show" is referenced in output. Do you mean treating
> "show" and "list" the same everywhere?

Almost all of iproute utils allow list, show, or lst.

You found a couple of places that may not.
Perhaps this will fix it.

From f65a5b0d0757ab7d9c57d0962ca903dd095ce20b Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen@...workplumber.org>
Date: Wed, 27 Mar 2024 16:55:09 -0700
Subject: [PATCH] ipila: allow show, list and lst as synonyms

Across ip commands show, list and misspelling lst are treated
the same.

Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
---
 ip/ipila.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ip/ipila.c b/ip/ipila.c
index f4387e03..80f34f29 100644
--- a/ip/ipila.c
+++ b/ip/ipila.c
@@ -301,7 +301,9 @@ int do_ipila(int argc, char **argv)
 		return do_add(argc-1, argv+1);
 	if (matches(*argv, "delete") == 0)
 		return do_del(argc-1, argv+1);
-	if (matches(*argv, "list") == 0)
+	if (matches(*argv, "show") == 0 ||
+	    matches(*argv, "lst") == 0 ||
+	    matches(*argv, "list") == 0)
 		return do_list(argc-1, argv+1);
 
 	fprintf(stderr, "Command \"%s\" is unknown, try \"ip ila help\".\n",
-- 
2.43.0