netdev - Re: [PATCH 02/19] Input: atlas:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZgWu-33aKyCOjRBX@google.com>
Date: Thu, 28 Mar 2024 10:55:07 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
	Robert Moore <robert.moore@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Benson Leung <bleung@...omium.org>,
	Tzung-Bi Shih <tzungbi@...nel.org>,
	Corentin Chary <corentin.chary@...il.com>,
	"Luke D. Jones" <luke@...nes.dev>,
	Hans de Goede <hdegoede@...hat.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>,
	Daniel Oliveira Nascimento <don@...t.com.br>,
	Pali Rohár <pali@...nel.org>,
	Matan Ziv-Av <matan@...alib.org>,
	Mattia Dongili <malattia@...ux.it>,
	Azael Avalos <coproscefalo@...il.com>,
	Richard Cochran <richardcochran@...il.com>,
	Jeff Sipek <jsipek@...are.com>, Ajay Kaher <akaher@...are.com>,
	Alexey Makhalov <amakhalov@...are.com>,
	VMware PV-Drivers Reviewers <pv-drivers@...are.com>,
	Theodore Ts'o <tytso@....edu>,
	"Jason A. Donenfeld" <Jason@...c4.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	acpica-devel@...ts.linux.dev, linux-input@...r.kernel.org,
	netdev@...r.kernel.org, chrome-platform@...ts.linux.dev,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 02/19] Input: atlas: - drop owner assignment

On Wed, Mar 27, 2024 at 08:43:49AM +0100, Krzysztof Kozlowski wrote:
> ACPI bus core already sets the .owner, so driver does not need to.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

But please fix the stray colon in the subject.

> 
> ---
> 
> Depends on the first patch.
> ---
>  drivers/input/misc/atlas_btns.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/misc/atlas_btns.c b/drivers/input/misc/atlas_btns.c
> index 3c9bbd04e143..5b9be2957746 100644
> --- a/drivers/input/misc/atlas_btns.c
> +++ b/drivers/input/misc/atlas_btns.c
> @@ -127,7 +127,6 @@ MODULE_DEVICE_TABLE(acpi, atlas_device_ids);
>  static struct acpi_driver atlas_acpi_driver = {
>  	.name	= ACPI_ATLAS_NAME,
>  	.class	= ACPI_ATLAS_CLASS,
> -	.owner	= THIS_MODULE,
>  	.ids	= atlas_device_ids,
>  	.ops	= {
>  		.add	= atlas_acpi_button_add,
> 
> -- 
> 2.34.1
> 

-- 
Dmitry