netdev - Re: kunit alltests runs broken in mainline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6591ea0d-572b-4deb-b2a7-da58ed91c8f9@linuxfoundation.org>
Date: Thu, 28 Mar 2024 14:08:40 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: David Gow <davidgow@...gle.com>, Johannes Berg
 <johannes@...solutions.net>, SeongJae Park <sj@...nel.org>
Cc: Jakub Kicinski <kuba@...nel.org>, Mark Brown <broonie@...nel.org>,
 Brendan Higgins <brendanhiggins@...gle.com>, Rae Moar <rmoar@...gle.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
 "kunit-dev@...glegroups.com" <kunit-dev@...glegroups.com>,
 "x86@...nel.org" <x86@...nel.org>, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: kunit alltests runs broken in mainline

On 3/26/24 04:09, David Gow wrote:
> On Tue, 26 Mar 2024 at 15:55, Johannes Berg <johannes@...solutions.net> wrote:
>>
>> On Tue, 2024-03-26 at 01:52 +0000, Jakub Kicinski wrote:
>>>
>>> I'm late to the party, but FWIW I had to toss this into netdev testing
>>> tree as a local patch:
>>>
>>> CONFIG_NETDEVICES=y
>>> CONFIG_WLAN=y
>>
>> I'll send this in the next wireless pull, soon.

You are welcome to send this with wireless pull if you like
or I can include it in my pull request.

Either way let me know:

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

>>
>>> CONFIG_DAMON_DBGFS_DEPRECATED=y
>>
>>> The DAMON config was also breaking UML for us, BTW, and I don't see
>>> any fix for that in Linus's tree. Strangeness.
>>
>> I noticed that too (though didn't actually find the fix) against net-
>> next, wireless trees are still a bit behind. I guess it'll get fixed
>> eventually.
>>
> 
> + Shuah, sj
> 
> Thanks for fixing this. I've sent out a fix (though I'm not 100% sure
> it's the right one) to the DAMON issue here:
> https://lore.kernel.org/linux-kselftest/20240326100740.178594-1-davidgow@google.com/
> 

I applied this to linux-kselftest kunit-fixes branch

I am planning to send this up tomorrow.

> I don't think it'd conflict with the wireless fix, but if so, I'm
> happy for them both to go in via KUnit if that's easier.
> 

thanks,
-- Shuah